Quote from: Quialiss on 06/18/2014 09:38 pmIs there an easy way to figure out what bits a DC correction changes?Example, i frame 4, these are effectively 3 single bitflips that fix the luma down in the clock region. The clock itself is still damaged, which might be fixable if these flips aren't single flips, but triple flips that just happen to have one part in a luma sub block...6:29:86644:64:0:0:0:0:0, 7:29:87881:0:-32:0:-64:0:0If dcs are off by that much (32 and 64) there are probably errors in dc size vlc codes, but I fear there is no easy way to figure out anything about that Is it a flip in dc size vlc or there's a flip before, which causes it to be read wrong? Go figure.edit: But if the clock itself is wrong the errors are obviously aready in the luma blocks so no wonder chromas are broken too. Sorry, you were already talking about luma. Still the error could be in the previous block, but dc_size luminance would be my best guess. I would just xor through the whole block if it hasn't been done already.
Is there an easy way to figure out what bits a DC correction changes?Example, i frame 4, these are effectively 3 single bitflips that fix the luma down in the clock region. The clock itself is still damaged, which might be fixable if these flips aren't single flips, but triple flips that just happen to have one part in a luma sub block...6:29:86644:64:0:0:0:0:0, 7:29:87881:0:-32:0:-64:0:0
All the mb's are 1000+ bits, not my favorite kind to do exhaustive searches through. Silly massive clock. I continued to mess with it, and actually got the numbers to show up quite nicely using some direction adjustment. I really wish the direction field was displayed in binary rather than decimal, it would make it so much easier to tweak. Not quite sure why it's screwed up considering direction's calculated on the fly, but it does work... I think there are a few more digits in the i frames I can recover this way.
Ours is better. Onboard hi-def camera of F9R test at McGregor yesterday (17-Jun). Now with steerable fins.
Quote from: Quialiss on 06/18/2014 11:32 pmAll the mb's are 1000+ bits, not my favorite kind to do exhaustive searches through. Silly massive clock. I continued to mess with it, and actually got the numbers to show up quite nicely using some direction adjustment. I really wish the direction field was displayed in binary rather than decimal, it would make it so much easier to tweak. Not quite sure why it's screwed up considering direction's calculated on the fly, but it does work... I think there are a few more digits in the i frames I can recover this way. Wow, brilliant. I just made an edit to my previous post to admit my utter failure. Looks like the root cause of the issue lies in fact in MB 5:28.
Made a new version of the additional frames. Feel free to comment, modify or simply make another, nicer version all the source data are in additional_frames.zip@ Wronkiew: I copy 40 times each frame for the video, if you want to add them to the online video.
@SwissCheese:I've finished doing corrections on part 4, I did make two small alignment changes, could you double check them? frame 71 -- 24:7:25925 (and 37:10:36157 to keep the same alignment between the two pieces)frame 72 -- 23:18:35367
Ha ha, famous rocket cows of McGregor seem to adapt quite quickly
I attach a zip conatining folders each containing 40 mpg4-img files. They start with iframe and are followed by the 19 pframes of the section followed by P frame converted iframe of the next section and its subsequent p frames. Each folder also contains a txt file with the mmb for the converted frame (frame_21.mpg4-img in the folders). There is an issue with conversion for iframe 121 (in part5_6) I still have to investigate, might be bad vop_quant. I have modified some mmbs already with -3 commands for the blank regions (part3_4, part12_13 and part14_15). Others remain to be done, but probably require more dc tweaking.
I tried a bit for i frame 221, but we really need the data in the online editor to tune the dc values I think, it takes too much time without it.Also made a video (spacex_landing_i2p.mp4) with your conversions (part3_4, part12_13 and part14_15).
Quick poll - How many hours have you put into this since it began almost twelve weeks ago?To avoid clutter, PM me. I will post anonymous stats (hi, low, avg, total)(My guess is the core team effort is around 12,000-14,000 person-hours.)
There is an issue with conversion for iframe 121 I still have to investigate, might be bad vop_quant.
Quote from: SwissCheese on 06/18/2014 10:47 pmMade a new version of the additional frames. Feel free to comment, modify or simply make another, nicer version all the source data are in additional_frames.zip@ Wronkiew: I copy 40 times each frame for the video, if you want to add them to the online video.Looks great! I'll put those into the generated videos. Probably tomorrow.How do folks feel about putting real names into the credits list? I wouldn't want to do it unless we had significant buy-in from the contributors.
Quote from: SwissCheese on 06/19/2014 01:52 pmI tried a bit for i frame 221, but we really need the data in the online editor to tune the dc values I think, it takes too much time without it.Also made a video (spacex_landing_i2p.mp4) with your conversions (part3_4, part12_13 and part14_15).Online editor would be indeed be really helpful. I hope IainCole gets a chance to do it. I'm also contemplating trying to make an automatic dc fixing tool. I believe it should be possible because we already know the (more or less) correct dcs for all blocks, they can be extracted from the fixed iframe ffmpeg logs.
Yeah it's going to require some major surgery so might take a while, I should have some time to tackle it on Saturday maybe.
Looks great! I'll put those into the generated videos. Probably tomorrow.
There is a way to use the current online editor to fix dcs in converted frames. -3 mbs appear to have the same effect on dcs as -2 mbs. Open two online editors with the frame you want to fix. In one set the region you want to be -3 to -2. Select the blocks starting the dc issues and see what the dcs are, in the other tab see what they should be. Add/subtract the difference. dcs are now fixed, put them into the converted frame mmb.edit: Use iframe only editor if you value you sanity.